Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (paymenthelpers, paymentelement) promise being unresolved #297

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: (paymenthelpers, paymentelement) promise being unresolved #297

merged 2 commits into from
Apr 17, 2024

Conversation

prafulkoppalkar
Copy link
Contributor

Description

For users it looked like Promise is being unresolved as the button was being stuck in the loading state.

  • Ready promise was not getting created
  • Ready message was not being sent to create the promise (missed one edge case)
  • Return the appropriate msg and resolve the promise in the case of empty PML instead of () empty function
  • Send Ready msg even in the case of Semiloaded -> LoadError state cuz this will have card form by default.
  • Do not make /confirm call if the PML response is empty. Resolve the promise and throw a warning on console

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@prafulkoppalkar
fix(paymenthelpers, paymentelement): promise being unresolved for man…
4f9fa8a 
…date payment

For end users it looked like Promise is being unresolved as the button was being stuck in the
loading state.
@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Apr 16, 2024
@prafulkoppalkar prafulkoppalkar changed the title fix(paymenthelpers, paymentelement): promise being unresolved for mandate payments fix(paymenthelpers, paymentelement): promise being unresolved Apr 16, 2024
@prafulkoppalkar prafulkoppalkar added Ready for Review PR with label Ready for Review should only be reviewed. and removed S-conventions-not-followed Some Github conventions not followed labels Apr 16, 2024
@prafulkoppalkar prafulkoppalkar changed the title fix(paymenthelpers, paymentelement): promise being unresolved fix: (paymenthelpers, paymentelement) promise being unresolved Apr 17, 2024
@prafulkoppalkar prafulkoppalkar merged commit 6494f51 into main Apr 17, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the fix/confirm_handling_empty_pml branch April 17, 2024 09:20
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Apr 17, 2024
akash-c-k pushed a commit that referenced this pull request Apr 17, 2024
@semantic-release-bot
chore(release): 0.42.3 [skip ci]
38e8e8b 
## [0.42.3](v0.42.2...v0.42.3) (2024-04-17)

### Bug Fixes

* (paymenthelpers, paymentelement) promise being unresolved  ([#297](#297)) ([6494f51](6494f51))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
@rising-dragon401
chore(release): 0.42.3 [skip ci]
177aa7a 
## [0.42.3](juspay/hyperswitch-web@v0.42.2...v0.42.3) (2024-04-17)

### Bug Fixes

* (paymenthelpers, paymentelement) promise being unresolved  ([#297](juspay/hyperswitch-web#297)) ([6494f51](juspay/hyperswitch-web@6494f51))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArushKapoorJuspay ArushKapoorJuspay ArushKapoorJuspay approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Assignees
No one assigned
Labels
Closed Label will be automatically added when the PR will get merged to main Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prafulkoppalkar @PritishBudhiraja @ArushKapoorJuspay